New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of PRAGMA Key to encrypt db #1018
Open
K3yr0nym0us
wants to merge
77
commits into
revert-982-linux-image-bump
Choose a base branch
from
master
base: revert-982-linux-image-bump
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com>
* Move repetitive build commands into environment variables (#989) * Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> * restore "env." prefixes to NODE_BUILD_CMD and ELECTRON_BUILD_CMD --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> Co-authored-by: Matthew McEachen <matthew@photostructure.com>
* Add support for Node v20 prebuilds * Also test v20
Remove node.js v14 builds and testing (runtime EOL)
* Fix out-of-bounds read in statement tail parser * Add comment with link to tail parsing issue * Fix missing increment in tail parser + tests
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
Prebuild for Node on other architectures as well
Run `ncu -u`
Fix buffer create in sandbox mode (electron)
Fix: Allow building with space in path
From the docs: > This option is obsolete. It used to enable some extra some extra > PRAGMA statements such as PRAGMA function_list, PRAGMA module_list, > and PRAGMA pragma_list, but those pragmas are now all enabled by > default. See SQLITE_OMIT_INTROSPECTION_PRAGMAS. It has been obsolete since 2019-10-04 (with SQLite 3.30.0).
* Added `webpack` support * changed from `webpack_require` to `non_webpack_require` * Update database.js Added URL to webpack documentation * feat(database): now `nativeBinding` supports addon object * style(package): line break removed --------- Co-authored-by: Matthew McEachen <matthew@photostructure.com>
added HAVE_USLEEP=1 compile-time option
As I remember, we had a prior conversation about this and @JoshuaWise mentioned that it would not be wise to make this library rely on another third-party extension which isn't guaranteed to be maintained. That's why I decided to create the |
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
* update prebuild for latest abi versions * conditional build for Electron 29 and higher * add Electron 29 to prebuild versions
Fixes warnings like at the bottom right of https://github.com/WiseLibs/better-sqlite3/actions/runs/7997686043 * https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot * https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem
Bumps the github-actions group with 4 updates: [actions/checkout](https://github.com/actions/checkout), [actions/setup-node](https://github.com/actions/setup-node), [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) and [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action). Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) Updates `actions/setup-node` from 3 to 4 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) Updates `docker/setup-qemu-action` from 1 to 3 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v1...v3) Updates `stefanzweifel/git-auto-commit-action` from 4 to 5 - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: stefanzweifel/git-auto-commit-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update SQLite to version 3.45.2 * fix specs --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> Co-authored-by: Matthew McEachen <matthew@photostructure.com>
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
There were a bunch of windows instructions that aren't relevant anymore (Node.js on windows just works if you "install the necessary tools" now!)
fix macos setuptools workaround
…1182) Drop unsupported versions of node and electron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally, I think that a Sqlite database that has so many features and improvements but that has no way to make it secure seems to me to be of little use, even so, I will use it with the hope that one day it will be able to encrypt its data.