Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update prebuild and remove node-gyp version override #1059

Merged
merged 1 commit into from
Oct 10, 2023
Merged

update prebuild and remove node-gyp version override #1059

merged 1 commit into from
Oct 10, 2023

Conversation

neoxpert
Copy link
Contributor

Since prebuild has updated it's dependency to the latest node-gyp version 9.4.0, the version override may no longer be required.

@neoxpert neoxpert requested review from JoshuaWise and a team as code owners September 10, 2023 11:26
mceachen
mceachen approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mceachen mceachen merged commit ce10309 into WiseLibs:master Oct 10, 2023
14 checks passed
@neoxpert neoxpert deleted the remove_nodegyp_override branch October 10, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mceachen mceachen mceachen approved these changes

@JoshuaWise JoshuaWise Awaiting requested review from JoshuaWise JoshuaWise is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neoxpert @mceachen