Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1021: Expose sqlite3 metadata #1124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

code-ape
Copy link

@code-ape code-ape commented Dec 31, 2023

Issues:

  1. Exposing the embedded SQLite3 version number and other compile-time variables #1021
  2. Allow easy way to get Sqlite3 version #1122

Changes:

  1. Exposed 49 sqlite3 metadata properties via .metadata property on the addon object, via src/better_sqlite3.lzz and src/better_sqlite3.cpp.
  2. Exposed the above mentioned .metadata property of the addon on the Javascript Database object, via lib/database.js.
  3. Added test to validate that above mentioned sqlite3 metadata 49 properties are as expected, via test/51.metadata.js and test/51.metadata.json.
  4. Added pragma test to validate that compile_options pragma does work for getting other compile time options, via test/12.database.pragma.js.
  5. Added to the download.sh automation script so it updates the test values of test/51.metadata.json whenever it is run, via deps/download.sh and deps/download_update_tests.sh.

test/51.metadata.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants