Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for electron v23 prebuilds #951

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Add support for electron v23 prebuilds #951

merged 1 commit into from
Feb 7, 2023

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented Feb 7, 2023

Stable Electron v23 was just released. Prebuilds are tested. ✅

@m4heshd m4heshd requested review from JoshuaWise and a team as code owners February 7, 2023 01:00
mceachen
mceachen approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mceachen mceachen merged commit f68d8ba into WiseLibs:master Feb 7, 2023
@Prinzhorn
Copy link
Contributor

Thanks to both of you for handling this so swiftly!

@mayankja1n
Copy link

Do these prebuilds help this package work with electron v23? If so how can I use them to make it work with electron?

@mceachen
Copy link
Member

Do these prebuilds help this package work with electron v23? If so how can I use them to make it work with electron?

Please refer to this pinned issue: #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mceachen mceachen mceachen approved these changes

@JoshuaWise JoshuaWise Awaiting requested review from JoshuaWise JoshuaWise is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m4heshd @Prinzhorn @mayankja1n @mceachen