Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unflag custom reports #2554

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Apr 4, 2024

Removing custom reports from feature flag "experimental" state.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 4, 2024
@github-actions github-actions bot changed the title Unflag custom reports [WIP] Unflag custom reports Apr 4, 2024
@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2468358
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66579d730611c200080213ed
😎 Deploy Preview https://deploy-preview-2554.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.72 MB → 4.72 MB (-293 B) -0.01%
Changeset
File Δ Size
src/components/settings/Experimental.tsx 📉 -145 B (-4.45%) 3.18 kB → 3.04 kB
src/hooks/useFeatureFlag.ts 📉 -24 B (-6.03%) 398 B → 374 B
src/components/reports/Overview.tsx 📉 -124 B (-6.19%) 1.96 kB → 1.83 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3 MB → 3 MB (-169 B) -0.01%
static/js/ReportRouter.js 1.23 MB → 1.23 MB (-124 B) -0.01%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/narrow.js 59.97 kB 0%
static/js/wide.js 263.11 kB 0%

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@carkom
Copy link
Contributor Author

carkom commented Apr 4, 2024

I think I'm ready to remove custom reports from experimental. It's fairly stable at this point. It has most everything I planned to add to it. Still plenty more to add and a couple things to fix but I don't think they are big issues that should stop it from going "live". Please share your thoughts.

@youngcw
Copy link
Contributor

youngcw commented Apr 4, 2024

I think my main hangup would be that live date ranges don't update for dashboard cards without going in and updating the report. Its not a big deal since work will still go on.

@carkom
Copy link
Contributor Author

carkom commented Apr 4, 2024

I think my main hangup would be that live date ranges don't update for dashboard cards without going in and updating the report. Its not a big deal since work will still go on.

Yea, it's at the top of my list right now. I'll try to put in a PR this weekend to fix that.

@MatissJanis
Copy link
Member

I'd recommend not rushing into this prematurely. The feature still seems quite unstable (judging from the amount of bug reports coming in). Could we hold off a bit more to gather some more feedback before calling it a stable feature?

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 27, 2024
@carkom carkom removed the Stale label May 27, 2024
@carkom
Copy link
Contributor Author

carkom commented May 29, 2024

I'd recommend not rushing into this prematurely. The feature still seems quite unstable (judging from the amount of bug reports coming in). Could we hold off a bit more to gather some more feedback before calling it a stable feature?

Heya, I know this comment is 2 months old but the bug reports you mention were very small issues that were directly related to newer features and were fixed quite easily. The only reason I said stable is that we've gone several months without any major issues with the feature.

Fast forward to today - since opening this PR, I've requested feedback on the stability of the feature and fixed all (very minor, most visual) issues reported. I've also converted 100% of the code to strict TS and submitted several code hardening PRs to make this feature ready for release.

If there are any further concerns I'm happy to address them. I am currently very confident in propsing this feature is removed from experimental for the next release (v24.7).

@MatissJanis
Copy link
Member

Sounds like a good plan!

@youngcw youngcw linked an issue Jun 3, 2024 that may be closed by this pull request
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP Still work-in-progress, please don't review and don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feedback]: Custom Reports
3 participants