Avoid using underlines for emphasis #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trafico-bot
bot
added
🚧 WIP
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
psybers
changed the title
trafico-bot
bot
added
🔍 Ready for Review
|
joel-jeremy
approved these changes
May 16, 2024
trafico-bot
bot
added
✅ Approved
|
This text is emphasized inside a |
trafico-bot
bot
added
✨ Merged
2 tasks
VoltaicGRiD
pushed a commit
to VoltaicGRiD/actual
that referenced
this pull request
May 31, 2024
# This is the 1st commit message: Avoid using underlines for emphasis (actualbudget#2765) * Avoid using underlines for emphasis * add release note # This is the commit message actualbudget#2: Updated tooltip / floating menu style to add a border for ease-of-visibility and accessibility (actualbudget#2779) Changed: - /packages/desktop-client/stc/style/style.ts - /packages/desktop-client/src/components/tooltips.tsx Updated to include a border: - color: theme.menuItemBackgroundHover - Used this color since its clean and maches the overall theming regardless of color palette - width: 2px - Not too thin, not too thick - style: solid - So it actually displays Changed color of tooltip to be more "vocal" against the background on all themes Uses `theme.menuItemTextHeader` color now Added whole style for 'tooltipXYZ' for each theme to add definition to colors (actualbudget#2779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2655.