-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Reports: Table Totals Callback #2768
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Hrm, I wonder if #2643 might be interfering here? Using the test budget. Starting from default: Clicking on the total returns no results: Change type to deposit: Returns payments: Change type to net: Deposit total and payment total as above, total total returns deposit and payments. Changing to Mode: Time Jan - no results: Change type to deposit - see payments and deposits: Change type to net - see payments and deposits: |
Yea looks to be the case. I'll keep that regression fix to a separate PR since it's also not working for any of the other graphs. This PR is concerned about the totals row call back and not to with the showActivity clicks. Good call out though as I didn't know we'd created a bug with that PR. |
How can I reproduce the bug on edge? |
Open a new custom report. Click table graph. Click time. Click a cell to go to accounts page. Click browser back button. Notice that the totals row has a bunch of 0s before the actual data starts. |
packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx
Outdated
Show resolved
Hide resolved
…ph/ReportTableRow.tsx Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Creating a callback for the table totals to fix a bug that created duplicate columns while rendering.