Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move rollover arrow into view #2774

Merged
merged 5 commits into from
May 21, 2024

Conversation

Tigatok
Copy link
Contributor

@Tigatok Tigatok commented May 17, 2024

ref: #2757

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 17, 2024
@github-actions github-actions bot changed the title fix: move rollover arrow into view [WIP] fix: move rollover arrow into view May 17, 2024
Copy link

netlify bot commented May 17, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c549133
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6647f1da842de700092f367a
😎 Deploy Preview https://deploy-preview-2774.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.72 MB → 4.72 MB (+74 B) +0.00%
Changeset
File Δ Size
src/components/budget/BalanceWithCarryover.tsx 📈 +74 B (+4.83%) 1.5 kB → 1.57 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3 MB → 3 MB (+74 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.97 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.54 kB 0%
static/js/wide.js 261.78 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented May 17, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@Tigatok Tigatok force-pushed the actual-2757-arrow-obsured branch from aebce30 to 9f7bd93 Compare May 17, 2024 22:30
@joel-jeremy
Copy link
Contributor

We would probably need to set different positions for mobile and desktop:
image

@Tigatok
Copy link
Contributor Author

Tigatok commented May 17, 2024

@joel-jeremy Just getting into this repo, is there a better way than using negative positions all together?
Maybe consider an underlined arrow or something?

Thoughts?
image

@joel-jeremy
Copy link
Contributor

joel-jeremy commented May 17, 2024

You can use isNarrowWidth from useResponsive hook to set different margins between narrow width devices (mobile) and desktop

@Tigatok
Copy link
Contributor Author

Tigatok commented May 17, 2024

Added isNarrowWidth check as previously mentioned.

image
image

@joel-jeremy
Copy link
Contributor

Thanks! There is a lint error. One last thing - please add a release note. See: https://actualbudget.org/docs/contributing/#writing-good-release-notes

@Tigatok
Copy link
Contributor Author

Tigatok commented May 17, 2024

@joel-jeremy I'll address lint issue. There should be a release note already, though it was a late addition:

Fixed the bugfix name

https://github.com/actualbudget/actual/pull/2774/files#diff-14138b72ad66fd61295509aafbb1d1b371b2e75be895f01210732e5188f733da

@Tigatok Tigatok force-pushed the actual-2757-arrow-obsured branch from 201c453 to 141fb45 Compare May 17, 2024 23:21
@Tigatok Tigatok changed the title [WIP] fix: move rollover arrow into view fix: move rollover arrow into view May 17, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 17, 2024
@youngcw youngcw linked an issue May 20, 2024 that may be closed by this pull request
2 tasks
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 20, 2024
@joel-jeremy joel-jeremy merged commit bbc123c into actualbudget:master May 21, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rollover Overspending arrow icon obscured by scroll bar
3 participants