♻️ (tooltip) refactoring to react-aria (vol.7)

[MatissJanis]

Refactoring custom reports usages of the old Tooltip component to react-aria.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	2b90261
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66491dc8a8a7fe0008f8d6ed
😎 Deploy Preview	https://deploy-preview-2778.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.72 MB → 4.72 MB (+886 B)	+0.02%

Changeset

File	Δ	Size
src/components/common/MenuButton.tsx	📈 +98 B (+27.68%)	354 B → 452 B
src/components/reports/SaveReport.tsx	📈 +836 B (+16.05%)	5.09 kB → 5.9 kB
src/components/reports/reports/CustomReportListCards.tsx	📈 +768 B (+9.04%)	8.29 kB → 9.04 kB
src/components/common/MenuTooltip.tsx	📈 +2 B (+0.90%)	222 B → 224 B
src/components/reports/SaveReportName.tsx	📉 -23 B (-1.00%)	2.24 kB → 2.22 kB
src/components/reports/ReportSidebar.tsx	📉 -235 B (-1.44%)	15.94 kB → 15.71 kB
src/components/reports/SaveReportChoose.tsx	📉 -122 B (-4.40%)	2.71 kB → 2.59 kB
src/components/reports/SaveReportDelete.tsx	📉 -113 B (-7.95%)	1.39 kB → 1.28 kB
src/components/reports/SaveReportMenu.tsx	📉 -128 B (-8.88%)	1.41 kB → 1.28 kB
src/components/reports/GraphButton.tsx	📉 -197 B (-23.29%)	846 B → 649 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.23 MB → 1.23 MB (+786 B)	+0.06%
static/js/wide.js	261.78 kB → 262 kB (+224 B)	+0.08%

Smaller

Asset	File Size	% Changed
static/js/AppliedFilters.js	20.54 kB → 20.41 kB (-124 B)	-0.59%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	59.97 kB	0%
static/js/index.js	3 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

[carkom]

A couple regressions that need fixed:

• Small nit - the buttons used to highlight even while the menu was open.
• The bottom border of the "Options" button gets covered by the menu (didn't used to)
• "Choose Graph" option in the main menu needs padding
  

[MatissJanis]

"Choose Graph" option in the main menu needs padding

Good catch! This one is now patched: 6ac0c4c

Small nit - the buttons used to highlight even while the menu was open.

Yea, there is a small visual difference between the old implementation and the new one we have.

The bottom border of the "Options" button gets covered by the menu (didn't used to)

Not quite sure what you mean.

Edge	PR

[carkom]

It seems to only be present in Firefox. Chrome is fine.
PR

Edge

[MatissJanis]

Interesting.. 🤔

Edge	PR

[MatissJanis]

Added 1px offset. Though this will affect all the popovers.

[carkom]

LGTM!