defaultPublicPath argument to methodName function #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's required to modify the publicPath while taking the defaultPublicPath as a parameter
Usecase: Multiple webpack builds on same page: and defaultPublicPath for each is something like: //mydomain.com/static/<APP_NAME>/
now I need to change it to //myOtherDomain.com/static/<APP_NAME>/
therefore, if I use the plugin like so:
new WebpackRequireFrom({methodName: '__get_public_path__'})
and have __get_public_path__ defined like so:
window.__get_public_path__ = defaultPublicPath => defaultPublicPath.replace('myDomain', 'myOtherDomain')
I would be able to achieve it for all apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's required to modify the publicPath while taking the defaultPublicPath as a parameter
Usecase: Multiple webpack builds on same page: and defaultPublicPath for each is something like: //mydomain.com/static/<APP_NAME>/ now I need to change it to //myOtherDomain.com/static/<APP_NAME>/
therefore, if I use the plugin like so:
new WebpackRequireFrom({methodName: 'get_public_path'})
and have get_public_path defined like so:
window.get_public_path = defaultPublicPath => defaultPublicPath.replace('myDomain', 'myOtherDomain')
I would be able to achieve it for all apps