fix(queries): prevent network request #6205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cfe8d23:
|
dhayab
reviewed
May 17, 2024
Comment on lines
+476
to
+485
| if (localInstantSearchInstance && widget.dependsOn === 'recommend') { | ||
| localInstantSearchInstance._hasRecommendWidget = true; | ||
| } else if (localInstantSearchInstance) { | ||
| localInstantSearchInstance._hasSearchWidget = true; | ||
| } else if (widget.dependsOn === 'recommend') { | ||
| hasRecommendWidget = true; | ||
| } else { | ||
| hasSearchWidget = true; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Should the values be reset to false somewhere before?
There was a problem hiding this comment.
I guess you don't know when another index still has widgets 🤔 in testing this seemed to repress the request though
There was a problem hiding this comment.
Ah yes I forgot about that. I'm fine with this then.
dhayab
approved these changes
May 17, 2024
Haroenv
added a commit
that referenced
this pull request
May 21, 2024
dhayab
pushed a commit
that referenced
this pull request
May 21, 2024
dhayab
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In index and instantsearch, keep track of which type of widgets are used, and only send a request of the right type.
Result
If only recommend or search widgets are present, only that request is done.
This has slight further impact to ensure that a render still happens when only recommend returns results.
FX-2892