copies static methods to HOC #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just use |
|
Ummm..yes. Let me research that and modify the Pr. |
|
Sounds good to me. Let me modify this Pr with that instead. |
|
That's up to @goatslacker 😄 |
|
otherwise looks good though? I added a test as well :) |
| @@ -47,6 +47,7 @@ | |||
| */ | |||
|
|
|||
| import React from 'react' | |||
| import hoistNonReactStatic from 'hoist-non-react-statics' | |||
There was a problem hiding this comment.
sure. was just copying that from the modules repo. update en route.
|
@taion updated. @goatslacker thoughts? |
|
I guess for now I can use same technique on the component returned from connect until this is merged in right? Just would be nice to include it inline with the other statics |
|
@goatslacker @taion should I just close this PR? |
|
@goatslacker @taion status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this copies static methods on the component class sent to connect to stores. this would be valuable for components that are at the top level, and in an SPA you may want to call fetch for server side rendering from a pre-defined method. this makes no assumptions on what the name of that method should be. you may also just want to call the fetch method before rendering, and being able to specify that in the component is nice.