chore: Wrap VRCSDK dependencies with AAO_VRCSDK3_AVATARS #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikoga
commented
Oct 19, 2023
|
conflict resolveしました |
anatawa12
force-pushed
the
remove_vrcsdk_deps
branch
from
0db5ecd
to
ed40683
Compare
|
対応していきます |
cosme なかったかーーーー |
kaikoga
force-pushed
the
remove_vrcsdk_deps
branch
from
796fe80
to
f492d6a
Compare
anatawa12
requested changes
Oct 24, 2023
kaikoga
force-pushed
the
remove_vrcsdk_deps
branch
from
66382cd
to
49f7241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #607
This PR wraps everything VRCSDK specific inside
#if AAO_VRCSDK3_AVATARSand remove any VRCAvatarDescriptor usage outside them, untilThis PR assumes all components would be supported without VRCSDK, excluding:
MergePhysBone: depends on PhysBoneClear Endpoint Position: depends on PhysBone