Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

Angular in .NET Core #2850

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Angular in .NET Core #2850

wants to merge 23 commits into from

Conversation

rexebin
Copy link
Contributor

@rexebin rexebin commented Nov 21, 2016

Here just so i can gather comments … DO NOT MERGE

Copy link
Contributor

@johnpapa johnpapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i started a review but didnt have time to go through it all. I'll do more later.


:marked
This cookbook describes how to build an Angular app inside the MVC architecture in a .NET Core Web application. It does not explain how Angular or .NET Core works. However it will provide all the code snippets required. Therefore you will be able to follow through this cookbook even if you are currently not familiar with Angular or .NET Core.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it may be helpful to have a short section here that identifies who the audience is

:marked
This cookbook describes how to build an Angular app inside the MVC architecture in a .NET Core Web application. It does not explain how Angular or .NET Core works. However it will provide all the code snippets required. Therefore you will be able to follow through this cookbook even if you are currently not familiar with Angular or .NET Core.

It is recommended that you follow this cookbook step by step and experience the challenges in the process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awkward sentence. Perhaps just remove it


It is recommended that you follow this cookbook step by step and experience the challenges in the process.

.NET Core supports cross platforms. You can develop .NET Core applications on Windows, macOS or Linux. This cookbook will use Visual Studio 2015 on Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest ...

.NET Core is a cross platform solution.

Saying the cookbook uses Windows makes me wonder what will be different on OSX on a Mac. I think it would be good to discuss both in the cookbook, otherwise we cut out a growing audience.

:marked
## Prerequisite

If you do not have them in your system, download and install the following items:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify ...

begin by downloading and installing the following requirements:


If you do not have them in your system, download and install the following items:

1. [Visual studio 2015 Update 3](https://go.microsoft.com/fwlink/?LinkId=691129)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Visual Studio ...

1. [Visual studio 2015 Update 3](https://go.microsoft.com/fwlink/?LinkId=691129)
1. [.NET Core Tools for Visual Studio 2015](https://go.microsoft.com/fwlink/?LinkId=691978)
1. [.Net Core SDK](https://go.microsoft.com/fwlink/?LinkID=835014)
1. [Typescript 2 for Visual Studio 2015](http://download.microsoft.com/download/6/D/8/6D8381B0-03C1-4BD2-AE65-30FF0A4C62DA/TS2.0.3-TS-release20-nightly-20160921.1/TypeScript_Dev14Full.exe)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be TypeScript ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this link likely to change? is there a safer one?

+makeExample('angular-in-dotnet-core/ts/_layout.html', null, 'Views/shared/_layout.cshtml')(format='.')

:marked
Now, build and run the application, you will find that .NET Core MVC application works but the Angular app does not. Open the the developer's tool in the browser, go to the console tab, you will find that the browser is complaining that it cannot find any of the scripts we inserted to `Views/Shared/_layout.cshtml` above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compound sentence. Try breaking it up.

Now build and run the application. The .NET Core MVC application works but the Angular app appears not to work! Let's find out why. Open the developer tools in the browser ...


#### 404 Errors

These 404 errors indicate that the browser could not find files in `app` and `node_modules` folders. But we have an `app` folder and a `node_modules` folder in the root directory, why the browser can not find it?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have app and node_modules folders, but why can't the browser find them?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants