Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

docs(forms-guide): explain heroForm reference better #3082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UnnDunn
Copy link

@UnnDunn UnnDunn commented Jan 7, 2017

The current forms guide uses the heroForm template reference variable without creating or explaining it first (see the last example in the "Add a Hero and Reset the Form" section). This could cause confusion and presents errors if someone is following along on their machine.

This change modifies that section to add the explanation before the variable is used.

The current forms guide uses the heroForm variable without
creating or explaining it first, which could cause confusion.
This change modifies that section to add the explanation
before the variable is used,
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@UnnDunn
Copy link
Author

UnnDunn commented Jan 7, 2017

I added my Git email address to my Google account. Is there a way to get Googlebot to re-check the CLA status?

Edit: Well OK then. :)

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added CLA: yes and removed CLA: no labels Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants