-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Remove legacy_dispatcher.ts which is no longer needed. #55784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caretaker note: cl/633635883 necessary to fix internal BUILD rule |
tbondwilkinson
added
the
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
label
May 14, 2024
TESTED=TGP |
pullapprove
bot
added
the
requires: TGP
This PR requires a passing TGP before merging is allowed
label
May 15, 2024
tbondwilkinson
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
core: event dispatch
area: core
Issues related to the framework runtime
and removed
requires: TGP
This PR requires a passing TGP before merging is allowed
labels
May 15, 2024
tbondwilkinson
added
the
requires: TGP
This PR requires a passing TGP before merging is allowed
label
May 15, 2024
tbondwilkinson
added
target: rc
This PR is targeted for the next release-candidate
and removed
area: core
Issues related to the framework runtime
labels
May 15, 2024
tbondwilkinson
force-pushed
the
jsaction-dispatcher
branch
from
May 15, 2024 18:57
aee6d68
to
fa3582f
Compare
tbondwilkinson
requested review from
rahatarmanahmed
and removed request for
csmick
May 15, 2024 18:58
rahatarmanahmed
approved these changes
May 15, 2024
AndrewKushnir
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only 1 minor non-blocking proposal) 👍
Also use `dispatchDelegate` by default for `eventReplayer`.
tbondwilkinson
force-pushed
the
jsaction-dispatcher
branch
from
May 17, 2024 19:29
b27b26c
to
b15d589
Compare
tbondwilkinson
removed
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
May 17, 2024
tbondwilkinson
added
the
action: merge
The PR is ready for merge by the caretaker
label
May 17, 2024
AndrewKushnir
approved these changes
May 17, 2024
This PR was merged into the repository by commit 834e627. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
core: event dispatch
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
requires: TGP
This PR requires a passing TGP before merging is allowed
target: rc
This PR is targeted for the next release-candidate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use
dispatchDelegate
by default foreventReplayer
.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?