-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove React 16.4's obsolete React imports #28571
Open
hainenber
wants to merge
10
commits into
apache:master
Choose a base branch
from
hainenber:remove-unused-react-imports
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,360
−1,880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
requested review from
villebro,
rusackas,
michael-s-molina,
geido and
kgabryje
as code owners
May 18, 2024 09:29
github-actions
bot
added
plugins
packages
and removed
change:frontend
Requires changing the frontend
labels
May 18, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
changed the title
chore: remove unused React imports
chore: remove obsolete React imports
May 18, 2024
Converting this to |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…tic JSX runtime bundling Signed-off-by: hainenber <dotronghai96@gmail.com>
This is required to pass corresponding Jest test. Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
changed the title
chore: remove obsolete React imports
chore: remove React 16.4's obsolete React imports
May 19, 2024
Phew! I've worked out all the edge cases and CI is green now, re-open for review :D |
Thank you for the PR @hainenber. Can we add a lint rule to prevent unused React imports? |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
I've added the lint rule as requested :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
change:frontend
Requires changing the frontend
dependencies:npm
doc
Namespace | Anything related to documentation
packages
plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: remove unused React imports
SUMMARY
React imports are no longer necessary starting from React 16.4.0 (source), I ran
npx react-codemod update-react-imports
. Afterwards, I executed this snippet to confirm everything stays intactNotable changes:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
All CI should be green
ADDITIONAL INFORMATION