Allow Codec#product to behave correctly with parameter count #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this is implemented is via a
parameters: Int
onEncoder
.Notes:
State[Int, String]
solution from Skunk was attempted, but there was no way to prevent the bad behavior of(someNonUnit, Codec.unit).tupled
from generating(?, ?, ?,)
rather than(?, ?, ?)
. A possible solution to this issue isState[Int, List[Either[String, Int]]]
, where the transitionsLeft→Left
,Left→Right
,Right→Left
are directly concatenated, but transitionsRight→Right
are joined with,
.${ a *: b *: nil }
, and I don't know why.Encoder#either
in this case.def parameters = 1
6 times.