-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lua] suggestion: move canvas behind foreground dialog #4465
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
class DialogWindow : public ui::Window, | ||
public EditorObserver { | ||
public: | ||
bool moveTool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: member variable 'moveTool' has public visibility [misc-non-private-member-variables-in-classes]
bool moveTool;
^
ToolBar::instance()->selectTool(m_oldTool); | ||
} | ||
|
||
void onOpen(Event& ev) override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: parameter 'ev' is unused [misc-unused-parameters]
void onOpen(Event& ev) override { | |
void onOpen(Event& /*ev*/) override { |
} | ||
} | ||
|
||
void onBeforeClose(CloseEvent& ev) override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: parameter 'ev' is unused [misc-unused-parameters]
void onBeforeClose(CloseEvent& ev) override { | |
void onBeforeClose(CloseEvent& /*ev*/) override { |
It would be useful to allow moving and zooming on canvas when showing dialog in foreground, similar to built-in filter dialogs, e.g. like so:
Without it things work same as before. It's really nice to have for previewing color adjustment or other intermediary changes to the image.
There's one problem though: it's still possible to use ctrl key to move layers which feels like a problem. Filters avoid this because the sprite is locked ("Sprite is used by backup/data recovery task") but I'm not sure it's okay to do so here because the script also needs to use it? I wonder if there is a simple solution to this.
I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md
I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing