S3 to S3 Replication in SAM #2062
Conversation
|
Hi @jorgetovar , thanks for the pull request. However, your submission does not represent a serverless pattern as we see it. Those are typically intended to be primarily IaC-focused implementations of 2-4 AWS services. Feel free to expand upon this and resubmit then. |
|
But I see a similar pattern here but with CDK |
|
Thanks for your feedback. We've discussed it and will accept this pattern, also given the pattern you referenced. I'll review your submission soon. |
|
@jorgetovar , do you still plan to work on this issue? |
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
…m/jorgetovar/serverless-patterns into jorgetovar-feature-s3-replication
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
…m/jorgetovar/serverless-patterns into jorgetovar-feature-s3-replication
There was a problem hiding this comment.
Thanks, @bfreiberg, for all the suggestions. They have been addressed in the pull request now.
|
Please let me know if there are any specific areas you'd like me to address or if you need any further information from my end. Thank you for your time and good advice |
|
Looks good in general. I've highlighted a few minor adjustments |
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
|
Please let me know if there are anything else to address or if you need any further information from my end. |
Looking forward to see if it's anything else missing. And thanks for all the assistance |
|
Looks pretty good, thanks for the updates. I highlighted two minor changes. It would be great if you could address them |
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
|
I will work on that today |
|
I just had my son, so I was a bit delayed. Link updated. Everything should be ready for the merge now. Thank you for the assistance |
|
Hello looking forward for any updates:) |
|
I'm really sorry but I missed the incorrect service name before. Once that is changed, the PR is good to go |
bfreiberg
added
Patterns Guardian approved
and removed
Patterns Guardian approved
labels
|
Hi @jorgetovar , the service name still hasn't been changed. Are you sure that you pushed your latest changes? |
|
That's strange. I have committed the suggestions and double-checked them, and they should be correct now. Sorry about that. |
…m/jorgetovar/serverless-patterns into jorgetovar-feature-s3-replication
|
Great, thanks @jorgetovar for your contribution. A developer advocate will merge your PR soon |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.