Added apigw-http-api-cognito-lambda-cdk pattern #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pputhran
requested changes
Apr 4, 2024
There was a problem hiding this comment.
This pattern is missing the example-pattern.json file. Please refer to the sample template provided here
Also please refer to the other comments regarding private and public endpoints and Lambda functions. Suggest renaming them to avoid any confusions.
apigw-http-api-cognito-lambda-cdk/lib/http-api-cognito-lambda-stack.ts
Outdated
Show resolved
Hide resolved
apigw-http-api-cognito-lambda-cdk/lib/http-api-cognito-lambda-stack.ts
Outdated
Show resolved
Hide resolved
apigw-http-api-cognito-lambda-cdk/lib/http-api-cognito-lambda-stack.ts
Outdated
Show resolved
Hide resolved
|
Hi Pawan, I've applied the requested changed. |
pputhran
requested changes
Apr 17, 2024
pputhran
added
invalid-example-pattern-file
and removed
missing-example-pattern-file
labels
|
Hi @pputhran - I've done the requested change. |
pputhran
requested changes
May 2, 2024
|
Hi @pputhran - I've done the requested change. |
pputhran
approved these changes
May 7, 2024
pputhran
added
valid-example-pattern-file
Patterns Guardian approved
and removed
requested-changes
invalid-example-pattern-file
labels
|
Hi @pputhran - I can see that the branch hasn't been merged yet. Is there anything missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
API Gateway HTTP API with Cognito pattern back with JWT Authorizer and integrated with two Lambda functions.