New serverless pattern - SQS-EBPipes-ECS-Task Typescript CDK #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfreiberg
reviewed
Apr 4, 2024
| image: ContainerImage.fromRegistry('public.ecr.aws/docker/library/alpine:edge'), | ||
| logging: LogDriver.awsLogs({ | ||
| streamPrefix: '/ecstask', | ||
| // logRetention: RetentionDays.ONE_DAY, |
There was a problem hiding this comment.
why is this commented out?
|
|
||
| // Give pipeRole permissions to consume from the SQS queue and run the ECS task | ||
| sqsQueue.grantConsumeMessages(pipeRole); | ||
| // sqsEventBridgePipeTargetLogGroup.grantWrite(pipeRole); |
There was a problem hiding this comment.
Why is this commented out, can it be removed?
| // create a EventBridge pipe which consumes events from SQS with batch size 1 and delivers events to CloudWatch log group sqsEventBridgePipeTargetLogGroup | ||
| const pipe = new pipes.CfnPipe(this, 'SQSEventBridgePipe', { | ||
| logConfiguration: { | ||
| level: 'TRACE', |
There was a problem hiding this comment.
No I had this in there during debugging I will clean this up and clean it all up.
| } | ||
| }, | ||
| roleArn: pipeRole.roleArn, | ||
| description: 'SQS EventBridge Pipe', |
There was a problem hiding this comment.
That description is not really descriptive
|
|
||
| // example test. To run these tests, uncomment this file along with the | ||
| // example resource in lib/eventbridge-pipes-sqs-to-ecs-task-cdk-typescript-stack.ts | ||
| test('SQS Queue Created', () => { |
There was a problem hiding this comment.
Do you plan on adding a test here?
There was a problem hiding this comment.
no removed the folder
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
… and remove unwanted trace logging configuration
bfreiberg
reviewed
Apr 16, 2024
There was a problem hiding this comment.
I think this file can be removed as you have no tests
|
Looks good, thanks for your contribution. A Developer Advocate will merge the changes and publish the pattern to serverlessland.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding a new pattern for triggering ECS Fargate tasks from matches SQS events via EventBridge Pipes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.