Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet #2244

Conversation

Gryczka
Copy link
Contributor

@Gryczka Gryczka commented Apr 12, 2024

Issue #, if available: #2243

Description of changes: Adding a new serverless pattern for a CloudFront Distribution with a CloudFront Function for Routing to Different Geo-Localized Content in an S3 Statically Hosted Website

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Gryczka and others added 6 commits April 22, 2024 10:34
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
@Gryczka
Copy link
Contributor Author

Gryczka commented Apr 30, 2024

@bfreiberg Let me know if there's anything else to address.

Copy link
Contributor

@bfreiberg bfreiberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few comments left

Gryczka and others added 3 commits May 2, 2024 11:26
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
reduce description to 150 characters
@Gryczka
Copy link
Contributor Author

Gryczka commented May 2, 2024

Thanks @bfreiberg accepted the changes and reduced the description to 150 characters.

@bfreiberg
Copy link
Contributor

Looks good, thanks for your contribution. A Developer Advocate will merge the changes and publish the pattern to serverlessland.com.

@julianwood julianwood merged commit 96b9ae9 into aws-samples:main May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants