-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New serverless pattern - cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet #2244
New serverless pattern - cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet #2244
Conversation
cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet/example-pattern.json
Outdated
Show resolved
Hide resolved
cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet/example-pattern.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
@bfreiberg Let me know if there's anything else to address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few comments left
cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet/example-pattern.json
Outdated
Show resolved
Hide resolved
cloudfront-cff-s3-geo-uri-rewrite-cdk-dotnet/example-pattern.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
reduce description to 150 characters
Thanks @bfreiberg accepted the changes and reduced the description to 150 characters. |
Looks good, thanks for your contribution. A Developer Advocate will merge the changes and publish the pattern to serverlessland.com. |
Issue #, if available: #2243
Description of changes: Adding a new serverless pattern for a CloudFront Distribution with a CloudFront Function for Routing to Different Geo-Localized Content in an S3 Statically Hosted Website
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.