feat: add cloudfront-s3-cdk-go pattern #2251
Conversation
| "gitHub": { | ||
| "template": { | ||
| "repoURL": "https://github.com/aws-samples/serverless-patterns/tree/main/cloudformation-s3-cdk-go", | ||
| "templateURL": "serverless-patterns/cloudformation-s3-cdk-go", |
There was a problem hiding this comment.
Please remove the projectFolder value from the templateFile. Please refer to some of the other Go examples that we have under Serverless patterns.
"template": {
"repoURL": "https://github.com/aws-samples/serverless-patterns/tree/main/cloudformation-s3-cdk-go",
"templateURL": "serverless-patterns/cloudformation-s3-cdk-go",
"projectFolder": "cloudfront-s3-cdk-go",
"templateFile": "cloudformation-s3-cdk-go.go"
}
```
There was a problem hiding this comment.
Hi @pputhran I have removed the projectFolder value and fixed a few cloudformation/cloudfront typos.
But could you point me toward one of the relevant go examples? None of the go cdk examples I see have an example-pattern.json present.
update linkedin profile value update github template values.
fix typo
fix typo
removing projectFolder value
|
Hi @pputhran I have removed the projectFolder value and fixed a few cloudformation/cloudfront typos. But could you point me toward one of the relevant go examples? None of the go cdk examples I see have an example-pattern.json present. |
|
Hi @pputhran just pinging back on whether you have a cdk go example json you could share. |
| ] | ||
| }, | ||
| "gitHub": { | ||
| "template": { |
There was a problem hiding this comment.
The projectFolder is the required field. Also since the cloudfront-s3-cdk-go.go was renamed, its throwing a new error. Can you rename this file to cloudfronts3-cdk-go.go?
Can you please update as below
"template": {
"repoURL": "https://github.com/aws-samples/serverless-patterns/tree/main/cloudformation-s3-cdk-go",
"templateURL": "serverless-patterns/cloudformation-s3-cdk-go",
"projectFolder": "cloudfront-s3-cdk-go",
"templateFile": "cloudfronts3-cdk-go.go"
}
You are right. I assumed there were a few examples already. My bad. Apologies. I have added my comments and if you can update them, I can then approve it. |
Issue #, if available: #2250
Description of changes: Adding a new pattern for CloudFront to S3 Static Site implemented using the CDK in Go.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.