-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helpers TS conversion] async functions/generators #16510
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57119 |
9271b6b
to
da76b15
Compare
Thank you very much for the extremely high quality PR! |
Merged, you can rebase |
@nicolo-ribaudo Sorry for the late response. I am a bit busy recently. I am going to continue working on the PR ASAP. |
da76b15
to
ac8b020
Compare
0a2f066
to
257f23a
Compare
c145ec8
to
d19a377
Compare
By the way, Ron Buckton has been doing a bunch of work recently to improve the types of iterators in TypeScript itself recently: microsoft/TypeScript#58243 (and related PRs) I don't know to what extent the babel helper types should equal the standard library types or if there are any lessons that can be learned from that work that would be applicable here, but I wanted to mention it given the timing :) |
@nicolo-ribaudo It appears the new helper generation script is not included in the Is it a blocking factor? |
We should get that CI job green, but I can take a look at it tomorrow |
961d6dc
to
f63cd60
Compare
f63cd60
to
ec2247c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry it took so long!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Migrate all async functions/generators related Babel helpers to TypeScript with reasonable types (and a huge amount of TypeScript exercise~).
The PR also introduces a small change to the helper building script.