Improve parsing of HTML tables containing whitespace #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered this from a client that keeps the text that they're going to paste into Trix in an Excel spreadsheet, where each individual cell is copy & pasted into a new Trix instance.
In Windows Excel, copying a single cell containing "Hello world" generates some horrific HTML markup that essentially boils down to:
Which Trix then formats as:
How about this change, which ignores text nodes when trying to determine if the current tr/td is the first element in the container?
h/t to @hooleyhoop for the excellent detective work