Skip to content

Commit

Permalink
fix: disable parameter cost check for now (#821)
Browse files Browse the repository at this point in the history
This creates compatibility issues with VRCF, as well as being
run in the wrong phase of processing in any case.

At some point this will need to be restored, as part of a new
NDMF processing phase that runs much later in the build.

Fixes: #813, #806
  • Loading branch information
bdunderscore committed Apr 15, 2024
1 parent b23c0c1 commit 8d64c63
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Editor/RenameParametersHook.cs
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@ private void SetExpressionParameters(GameObject avatarRoot, ImmutableDictionary<
}

expParams.parameters = parameters.ToArray();


/*
if (expParams.CalcTotalCost() > VRCExpressionParameters.MAX_PARAMETER_COST)
{
BuildReport.LogFatal("error.rename_params.too_many_synced_params", new[]
Expand All @@ -270,6 +271,7 @@ private void SetExpressionParameters(GameObject avatarRoot, ImmutableDictionary<
}
);
}
*/

avatar.expressionParameters = expParams;
}
Expand Down

0 comments on commit 8d64c63

Please sign in to comment.