fix: modular avatar parameters is super slow (#834)

bdunderscore · Apr 22, 2024 · c111b29 · c111b29
1 parent 3ebc4fb
commit c111b29
Showing 1 changed file with 21 additions and 14 deletions.
diff --git a/Editor/ParamsUsage/ParamsUsageEditor.cs b/Editor/ParamsUsage/ParamsUsageEditor.cs
@@ -36,23 +36,19 @@ public bool Visible
             }
         }
 
-        private void OnEnable()
-        {
-            #if UNITY_2022_1_OR_NEWER
-            ObjectChangeEvents.changesPublished += OnChangesPublished;
-            #endif
-            Recalculate();
-        }
-
 #if UNITY_2022_1_OR_NEWER
-        private void OnChangesPublished(ref ObjectChangeEventStream stream)
+        private bool _delayPending = false;
+
+        private void DelayRecalculate()
         {
+            _delayPending = false;
             Recalculate();
         }
-
-        private void OnDisable()
+        
+        private void OnChangesPublished(ref ObjectChangeEventStream stream)
         {
-            ObjectChangeEvents.changesPublished -= OnChangesPublished;
+            if (!_delayPending) EditorApplication.delayCall += DelayRecalculate;
+            _delayPending = true;
         }
 #endif
 
@@ -65,7 +61,18 @@ protected override VisualElement CreateInnerInspectorGUI()
             _legendContainer = _root.Q<VisualElement>("Legend");
             _usageBoxContainer = _root.Q<VisualElement>("UsageBox");
 
-            Recalculate();
+#if UNITY_2022_1_OR_NEWER
+            _root.RegisterCallback<AttachToPanelEvent>(_evt =>
+            {
+                ObjectChangeEvents.changesPublished += OnChangesPublished;
+                Recalculate();
+            });
+
+            _root.RegisterCallback<DetachFromPanelEvent>(_evt =>
+            {
+                ObjectChangeEvents.changesPublished -= OnChangesPublished;
+            });
+#endif
 
             return _root;
         }
@@ -101,7 +108,7 @@ private static IEnumerable<Color> Colors()
         private void Recalculate()
         {
             if (_root == null || !_visible) return;
-
+            
             var ctx = serializedObject.context as GameObject;
 
             if (ctx == null) return;