chore: fix compile warnings (#853)

bdunderscore · May 12, 2024 · c9db3de · c9db3de
1 parent 1c0be75
commit c9db3de
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 14 deletions.
diff --git a/Editor/Inspector/BlendshapeSyncEditor.cs b/Editor/Inspector/BlendshapeSyncEditor.cs
@@ -38,7 +38,7 @@ private void OnDisable()
             if (_window != null) DestroyImmediate(_window);
         }
 
-        protected virtual void OnDestroy()
+        protected override void OnDestroy()
         {
             base.OnDestroy();
             if (_window != null) DestroyImmediate(_window);

diff --git a/Editor/Inspector/MoveIndependently/MoveIndependentlyEditor.cs b/Editor/Inspector/MoveIndependently/MoveIndependentlyEditor.cs
@@ -24,7 +24,9 @@ protected override void OnInnerInspectorGUI()
 
         protected override VisualElement CreateInnerInspectorGUI()
         {
+#pragma warning disable CS0618 // Type or member is obsolete
             var root = uxml.Localize();
+#pragma warning restore CS0618 // Type or member is obsolete
             root.styleSheets.Add(uss);
 
             var container = root.Q<VisualElement>("group-container");

diff --git a/Editor/OptimizationPasses/GCGameObjectsPass.cs b/Editor/OptimizationPasses/GCGameObjectsPass.cs
@@ -123,7 +123,7 @@ private void MarkAll()
                         }
                     }
                 }
-                catch (MissingComponentException e)
+                catch (MissingComponentException _)
                 {
                     // No animator? weird. Move on.
                 }

diff --git a/Editor/RenameParametersHook.cs b/Editor/RenameParametersHook.cs
@@ -62,8 +62,6 @@ internal class RenameParametersHook
 
         private BuildContext _context;
 
-        private int internalParamIndex = 0;
-
         // TODO: Move into NDMF
         private ImmutableList<string> PhysBoneSuffixes = ImmutableList<string>.Empty
             .Add("_IsGrabbed")
@@ -325,13 +323,11 @@ GameObject obj
             {
                 rv = BuildReport.ReportingObject(p, () => CollectParameters(p, paramInfo.GetParameterRemappingsAt(p, true)));
             }
-
-            var willPurgeAnimators = false;
+
             foreach (var merger in obj.GetComponents<ModularAvatarMergeAnimator>())
             {
                 if (merger.deleteAttachedAnimator)
                 {
-                    willPurgeAnimators = true;
                     break;
                 }
             }

diff --git a/Runtime/ArmatureAwase/ArmatureLockJob.cs b/Runtime/ArmatureAwase/ArmatureLockJob.cs
@@ -17,7 +17,6 @@ internal sealed class ArmatureLockJob : IDisposable
         private Action _dispose;
 
         private bool _isValid = true;
-        private long _lastHierarchyCheck = -1;
         private Action _update;
 
         internal ImmutableList<(Transform, Transform)> RecordedParents;

diff --git a/Runtime/ScaleAdjuster/ScaleProxy.cs b/Runtime/ScaleAdjuster/ScaleProxy.cs
@@ -14,16 +14,11 @@ namespace nadena.dev.modular_avatar.core
     internal sealed class ScaleProxy : AvatarTagComponent
     {
 #if UNITY_EDITOR
-        void OnValidate()
+        protected override void OnValidate()
         {
             base.OnValidate();
             EditorApplication.delayCall += DeferredValidate;
         }
-
-        void OnDestroy()
-        {
-            base.OnDestroy();
-        }
 
         private void DeferredValidate()
         {