Add MA Merge VRM1 SpringBones #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikoga
force-pushed
the
vrm_merge_springbones
branch
from
5ea43f1
to
cae9aa7
Compare
|
ありがとうございます！この辺見れるのは1月中旬になるので少々お待ちください |
kaikoga
force-pushed
the
vrm_merge_springbones
branch
from
cae9aa7
to
bb6d89f
Compare
kaikoga
force-pushed
the
vrm_merge_springbones
branch
from
bb6d89f
to
19e180c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #467
Merge base PR first: UniVRM components support #569
This PR introduces
MA Merge VRM1 SpringBonescomponent, which adds SpringBone entries toVRM10Instance.This component does nothing when the target avatar is not VRM1.
I think there is nothing specific to this component that requires localization. Perhaps there could be some warning like "This component is ignored; supports VRM1 avatar only", but many other components that targets VRCSDK only have similar issue.
I have not yet added documents. Merging this PR reveals UniVRM support to end users, so documentation would block the next release once this PR is merged.
I don't know yet where to add documents. (It would be under
docs~/, but I worry that throwing VRM specific components into the Component reference section makes little sense to VRC users, when the entire components list is even more growing).