chore(config): make ApplyOnPlay non-persistent (#63)

CHANGELOG.md

@@ -10,10 +10,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 ### Fixed
-- Fixed an issue where apply on play might not work when multiple scenes are open (#61)
 
 ### Changed
 
+- Make Apply on Play non-persistent, as users seem to frequently have issues with it left turned off.
+
 ### Removed
 
 ### Security

Editor/Config.cs

@@ -26,25 +26,29 @@
 
 using System;
 using UnityEditor;
+using UnityEngine;
 
 #endregion
 
 namespace nadena.dev.ndmf.config
 {
-    public static class Config
+    internal class NonPersistentConfig : ScriptableSingleton<NonPersistentConfig>
     {
-        // Preserve apply-on-play config from pre-1.8 versions of Modular Avatar
-        private const string PREFKEY_APPLY_ON_PLAY = "nadena.dev.modular-avatar.applyOnPlay";
+        [SerializeField] public bool applyOnPlay = true;
+    }
+
 
+    public static class Config
+    {
         /// <summary>
         /// Controls whether NDMF transformations will be applied at play time.
         /// </summary>
         public static bool ApplyOnPlay
         {
-            get => EditorPrefs.GetBool(PREFKEY_APPLY_ON_PLAY, true);
+            get => NonPersistentConfig.instance.applyOnPlay;
             set
             {
-                EditorPrefs.SetBool(PREFKEY_APPLY_ON_PLAY, value);
+                NonPersistentConfig.instance.applyOnPlay = value;
                 NotifyChange();
             }
         }