ContactParameterProvider ParameterType #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
実際はアニメーター側で別の型として扱うことが多いのだ確定するのはどうかなと思ってみたいにしてました… |
|
「趣旨としてはbool（だけど実際intとかで定義されてたらそっちを優先する）」みたいな「趣旨としては」型をParameterNamespaceとかで定義すると良い……？ |
|
懸念的には #208 もtypeをこのまま定義すべきかどうかは議論か（しかし単にnullなのも微妙だと思う……） |
|
ユニットテストの更新も必要のようですね・・・ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContactParameterProviderのParameterTypeはreceiverTypeによって確定して良いのでは？