Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename NDMF Error Report to NDMF Console #222

Merged
merged 6 commits into from May 12, 2024

Conversation

Sayamame-beans
Copy link
Contributor

@Sayamame-beans Sayamame-beans commented Apr 8, 2024

resolve: #173

  • Error Report表記の変更
  • 日本語での一部表示内容の変更(ついでに変えました)
  • 内部名称を変更 (publicになっていたのでやっていません。表記以外変える必要が必ずしもある訳ではないので、この変更でBreaking Changeになるのが流石に少し申し訳なく…?)

@Sayamame-beans Sayamame-beans marked this pull request as ready for review April 8, 2024 11:42
@bdunderscore
Copy link
Owner

APIのほうは変更なしという方向で(コメントでその差を表記するといいかも?)
PR自体はNDMFに手が回ったら確認します

@Sayamame-beans
Copy link
Contributor Author

Sayamame-beans commented Apr 22, 2024

メモ: 今気付いたけど、ファイル末尾のエラーメッセージ部にerror reportって書いてある(日英)…直さないと

@Sayamame-beans
Copy link
Contributor Author

(コメントでその差を表記するといいかも?)

いまいちどこに載せれば良いか分からず…
こんな感じで良いでしょうか?

@Sayamame-beans
Copy link
Contributor Author

コメントの内容と位置を変更しました
しかし…こっちに書くべきだったりしますか?

/// <summary>
/// Contains any errors or warnings issued during a single build operation.
/// </summary>
public sealed class ErrorReport

yelandiealma added a commit to vrc-community-assets-tc-translators/ndmf that referenced this pull request May 6, 2024
bdunderscore#222
Has been changed to the version of this PR
bdunderscore pushed a commit that referenced this pull request May 12, 2024
#222
Has been changed to the version of this PR
@bdunderscore bdunderscore merged commit 960805b into bdunderscore:main May 12, 2024
7 checks passed
@Sayamame-beans Sayamame-beans deleted the rename-error-report branch May 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Reportウィンドウの名前を変えて欲しい
2 participants