Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVR support #111

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

NovaVoidHowl
Copy link

This merge request is to allow for smoother interaction between CVR (via OSC mod) and this app.
It adds the following features

  • auto operating mode detection (if target app is open already)
  • manual operating mode selection via --opmode option for start up

(note this version also includes all the features from my prior merge request (#94) so as/when this gets merged, that should be closed too)

@NovaVoidHowl
Copy link
Author

NovaVoidHowl commented Nov 26, 2022

note compiled version for this can be found at https://github.com/NovaVoidHowl/VRCFaceTracking/releases/tag/v4.1.0

@benaclejames
Copy link
Owner

Hey, your comments don't seem to correlate with file changes. Maybe you forgot to commit some of the features?
I'm only seeing the changes for port selection launch parameters and help launch params, am I missing something?
Thanks

feat(CVRSupport): added opMode switch
@NovaVoidHowl
Copy link
Author

@benaclejames , sorry about that I had committed the changes to the wrong branch at my end, the above commit should include all the new changes.

@NovaVoidHowl
Copy link
Author

just putting a hold on this merge, rebuilt it just now (using totally up-to-date branch data from your repo) and can see some further issues

@NovaVoidHowl NovaVoidHowl changed the title CVR support draft: CVR support Nov 26, 2022
@NovaVoidHowl NovaVoidHowl changed the title draft: CVR support CVR support Nov 26, 2022
@NovaVoidHowl
Copy link
Author

@benaclejames , Ok further error fixes added to support current main branch from your repo, tested and working just now
Hopefully it will pass your testing too.

@NovaVoidHowl
Copy link
Author

note compiled version for this can be found at https://github.com/NovaVoidHowl/VRCFaceTracking/releases/tag/v4.2

@benaclejames
Copy link
Owner

Hey, sorry for the late reply.

We've been discussing the future of VRCFT internally for quite a while now and merging compatibility for another game raises some questions as to what the true purpose of VRCFT is as an application.

We're currently waiting on @regzo2's new PRs to be finished to remove any SRanipal compatibility and will then most likely be pivoting to VRCFT becoming a parameter processing framework for VR in general as opposed to VRChat.
I'll get back to you when we start introducing these changes and talks get further regarding them.

Sorry to have kept you in the dark 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants