fix(users-context): phantom user #20253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the collection's selector when publishing it to viewers.
Changes the logic of the add_user_persistent_data action in users context, so that the user information already in the context is merged with the new one. Also, do not flip the logged out status of users added by user_persisted_data anymore.
|
Automated tests Summary✅ All the CI tests have passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes phantom user bug by changing the logic of the context action 'add_user_persistent_data' that was not correctly handling the transition of user roles. Some users were left with wrong logged out status because the context logic only updated its state when the added user was logged out.
Closes Issue(s)
Closes #20251