feat(html5): Added captionLocale property and related logic #20272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/users/SetUserCaptionLocaleMsgHdlr.scala
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts ☹ |
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/db/CaptionLangDAO.scala
Outdated
Show resolved
Hide resolved
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/db/CaptionLangDAO.scala
Outdated
Show resolved
Hide resolved
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/caption/CaptionApp2x.scala
Show resolved
Hide resolved
|
This pull request has conflicts ☹ |
|
Automated tests Summary✅ All the CI tests have passed! |
gustavotrott
approved these changes
May 27, 2024
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the
captionLocaleproperty to the user table and also changes related logic, so now it is possible for the user to "speak" and produce captions in one language and read captions in another one.Motivation
So with the plugins, and the upcoming migration of the typed captions, this PR will not only enhance the usability for the plugin dev, but it will also give them the opportunity to develop a translation plugin in which instead of transcript what one is saying, they will translate it, even though their
speechLocaleis different from what they are receiving in the captions.