Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: external video skipping #20273

Merged

Conversation

Scroody
Copy link
Collaborator

@Scroody Scroody commented May 15, 2024

What does this PR do?

This PR fixes an error with the external video, where as soon as the user started and external video session, the video would skip forward, the amount of time the video would skip depends on the latency.

Before fix:

Screencast.from.2024-05-15.10-25-50.webm

After fix:

Screencast.from.2024-05-15.10-18-48.webm

@ramonlsouza ramonlsouza added this to the Release 3.0 milestone May 15, 2024
@Scroody Scroody changed the title Fix external video skipping Fix: external video skipping May 15, 2024
@ramonlsouza ramonlsouza requested a review from antonbsa May 15, 2024 13:32
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

Copy link
Member

@antonbsa antonbsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and on a remote server and I'm not able to reproduce it anymore. Tried changing the presenter while playing the video, started sharing short and long videos, joining users after already started the video, and so on.
LGTM!

@ramonlsouza ramonlsouza merged commit 31cb980 into bigbluebutton:v3.0.x-release May 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants