-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): added a couple of features to support typed-captions migration #20292
base: v3.0.x-release
Are you sure you want to change the base?
Conversation
…nted most of the sidekickMenu
…nt and fixed wrong behaviors for the generic component sidekick content
Quality Gate passedIssues Measures |
This pull request has conflicts ☹ |
val msgEvent = BbbCommonEnvCoreMsg(envelope, event) | ||
bus.outGW.send(msgEvent) | ||
} | ||
CaptionDAO.insertOrUpdateAudioCaption(msg.body.transcriptId, meetingId, msg.header.userId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming this function if it will be used by TypedCaptions too.
And then your will need to inform the captionType
as a param.
What does this PR do?
This PR does essentially 3 things:
Other than that, there are a few bugs found in the data-channel flow such as the remove entry function not working, those are already fixed by now.
Motivation
As mentioned in the title of this PR it is made to support the new typed-captions plugin.
More
Closely related to the plugin SDK PR bigbluebutton/bigbluebutton-html-plugin-sdk#82