-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(settings): remove Tracker.Dependency
and trackers
#20294
refactor(settings): remove Tracker.Dependency
and trackers
#20294
Conversation
…ses in old format
Tracker.Dependency
and trackersTracker.Dependency
and trackers
This pull request has conflicts ☹ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has conflicts ☹ |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Automated tests Summary✅ All the CI tests have passed! |
3ef0be6
into
bigbluebutton:v3.0.x-release
What does this PR do?
Tracker.Dependency
from the Settings singleton and starts to use Apollo'smakeVar
.useSettings
hook for reactivity. You must pass which setting group you want as a parameter. For example,useSettings('application')
.withTracker
's which exclusively depended on the settings or minimongo collections.Closes Issue(s)
None
Motivation
One more step towards removing Meteor completely.