Fix the blocked camera icon on the main page #741

EasyVector · 2021-08-31T06:34:52Z

Dear developer:

Hello! I am the creator of issue #740, and I have fixed the blocked camera icon on the main page. I would genuinely appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!

Here is the screenshot after my changes. As you can see this navigation bar is scrollable now:

Thanks again! Blessings on your day! :)

Wahhe1 · 2021-09-04T04:32:18Z

Camera issue is resolved

schildbach · 2021-09-04T08:15:39Z

Thanks for your suggested fix. I must admit I'm not happy with making the bottom action bar scrollable – it doesn't really fix the problem.

My suggestions for resolving this are one of:

Make the strings shorter, e.g. shorten "Request coins" to just "Request". However this would need to be done for all translations too.
Allow the strings to wrap (will look ugly).
On small screens, move the "Request coins" action into the overflow menu.
Super quick fix: Just make sure that if the bottom action bar clips, it clips on the left instead of on the right, because the scan button is more important.

EasyVector · 2021-09-04T08:18:06Z

OK, please leave this to me. I would like to fix it in another way. :)

Thanks again!

EasyVector · 2021-09-06T09:50:20Z

Hello! Sorry for the wait, and I guess I have fixed this display problem. And here are screenshots after my fix:

I am not sure if it is right for you, and please let me know if you have any thoughts. Thank you so much! :)

EasyVector · 2021-09-06T15:14:17Z

Hi! I just found out that the texts are wrapped so I would like to enhance the display effect with ConstraintLayout and AppCompatTextView. And the result turns out well!!

I did some tests on Pixel 2 with API 25 and 29, and Pixel 3 XL with API 29. Here are the screenshots after my fix:

Pixel 2 with API 25:

Pixel 2 with API 29:

Pixel 3 XL with API 29

I am looking forward to your opinion. Thanks again! :)

EasyVector · 2021-09-07T09:09:28Z

Hi! I just realized that the XML code would be much tidier if I keep using LinearLayout instead of ConstraintLayout. So I made some changes to this and the effects are still the same. :)

schildbach

Can you explain you you're going to change the layout?

I can see from the screenshot there is now missing a bit of space at the top and bottom of the action bar.

schildbach · 2021-09-07T12:52:01Z

wallet/build.gradle

@@ -25,6 +25,7 @@ dependencies {
    implementation 'com.google.protobuf:protobuf-java:3.7.1'
    implementation 'com.google.guava:guava:29.0-android'
    implementation 'com.google.zxing:core:3.3.3'
+    implementation 'androidx.appcompat:appcompat:1.3.1'


The app deliberately isn't using AppCompat. I think you can archieve the same thing using the standard views.

OK, I will try to. The missing space is easy to handle. But could you tell me the reason why you deliberately do not use AppCompat? Is it because of some latent compatibility issues? Thanks.

schildbach · 2021-09-07T13:11:43Z

I'm proposing this simple change to fix clipping the scan button: #742

It will clip the request button instead, but that one is much bigger.

EasyVector · 2021-09-07T13:28:31Z

OK, how about this? I do not change the original layout and I manage to set some spaces above and below the scan icon. The texts inside those buttons are arranged in two lines now when the screen display size is the largest.

schildbach · 2021-09-09T08:49:06Z

fyi: I merged #742, so the issue now looks like this (without the ability to scroll): https://user-images.githubusercontent.com/25502419/131453646-293c91bf-1aed-4c9b-85b0-b5b9c9c78dcf.png

schildbach · 2021-09-09T08:57:04Z

The two-line buttons seem fine, although like I said I think it looks a bit ugly. However I think all it needs is overriding the singleLine attribute on the Buttons themselves – no need for a separate style and I guess also no need for all the other changes.

In your previous solution you made use of the auto scaling of AppCompatTextView. This feature is available on the framework's TextView too, on Android 8+.

General note: We don't yet use the start/end positions yet. I would prefer to use left/right for now and migrate the entire app to bidi layout at a later date.

Naywin220

Grek1313

0x09732C60Ba287Ac9226152ffe940c5E2Ca962EB8

Dorineb07

Approve

jimjohnson56 · 2022-08-04T10:26:45Z

wallet/res/layout/wallet_actions_fragment.xml

@@ -5,38 +5,37 @@
    android:theme="@android:style/ThemeOverlay.Material.Dark.ActionBar"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
+    android:paddingTop="@dimen/list_entry_padding_horizontal_cram"
+    android:paddingBottom="@dimen/list_entry_padding_horizontal_cram"
    android:measureWithLargestChild="true"
    android:orientation="horizontal">

    <Button


Best deals coming

Benson665 · 2022-11-08T08:21:32Z

Is quite fixed is more easier than before and more understanding to check in and out

Whiskey992 · 2022-11-08T08:23:21Z

Your welcome

…

On Tue., Nov. 8, 2022, 1:22 a.m. Benson665, ***@***.***> wrote: Is quite fixed is more easier than before and more understanding to check in and out — Reply to this email directly, view it on GitHub <#741 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3A6DRZUCXRJBLDLLM6H3O3WHIET3ANCNFSM5DDMMK6A> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

wallet/res/layout/wallet_actions_fragment.xml

    android:measureWithLargestChild="true"
    android:orientation="horizontal">

    <Button
        android:id="@+id/wallet_actions_request"
-        style="@style/My.Widget.ActionButton"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"


wallet/res/layout/wallet_actions_fragment.xml

@@ -5,38 +5,37 @@
    android:theme="@android:style/ThemeOverlay.Material.Dark.ActionBar"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
+    android:paddingTop="@dimen/list_entry_padding_horizontal_cram"
+    android:paddingBottom="@dimen/list_entry_padding_horizontal_cram"
    android:measureWithLargestChild="true"
    android:orientation="horizontal">

    <Button
        android:id="@+id/wallet_actions_request"


nElzky · 2023-11-15T06:26:47Z

Dear developer:

Hello! I am the creator of issue #740, and I have fixed the blocked camera icon on the main page. I would genuinely appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!

Here is the screenshot after my changes. As you can see this navigation bar is scrollable now:

Thanks again! Blessings on your day! :)

fixed the blocked camera icon on the main page

de3a3d1

EasyVector added 2 commits September 6, 2021 17:38

fix the blocked scan icon without using scrollview

b4a11fd

revoke changes applied to button tags

933e21e

fix the blocked scan icon with constraintlayout

8006915

replace constraint layout with linear layout

5df7f69

bitcoin-wallet deleted a comment from GHamidreza Sep 7, 2021

schildbach reviewed Sep 7, 2021

View reviewed changes

fix the blocked icon and keep the original layout structure

4ccf5f0

EasyVector changed the title ~~Fixed the blocked camera icon on the main page~~ Fix the blocked camera icon on the main page Sep 7, 2021

schildbach mentioned this pull request Sep 9, 2021

wallet_actions_fragment.xml: If the layout doesn't fit, clip the request button rather than the scan button. #742

Closed

berzaza27 approved these changes Jan 29, 2022

View reviewed changes

Naywin220 reviewed May 1, 2022

View reviewed changes

This comment was marked as spam.

Sign in to view

Grek1313 reviewed May 1, 2022

View reviewed changes

Dorineb07 approved these changes May 2, 2022

View reviewed changes

bitcoin-wallet deleted a comment May 4, 2022

jimjohnson56 reviewed Aug 4, 2022

View reviewed changes

Vicen811226 referenced this pull request Dec 8, 2022

9.26

787e997

nadinenpendleton approved these changes Jan 29, 2023

View reviewed changes

nadinenpendleton reviewed Jan 29, 2023

View reviewed changes

jimjohnson56 approved these changes Aug 7, 2023

View reviewed changes

bitcoin-wallet deleted a comment from Bigjohn2396 Aug 8, 2023

bitcoin-wallet deleted a comment Aug 8, 2023

bitcoin-wallet deleted a comment from try2nks Aug 9, 2023

This comment was marked as spam.

Sign in to view

nElzky approved these changes Nov 15, 2023

View reviewed changes

bitcoin-wallet deleted a comment from Devineonline99 Mar 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the blocked camera icon on the main page #741

Fix the blocked camera icon on the main page #741

EasyVector commented Aug 31, 2021

Wahhe1 commented Sep 4, 2021

schildbach commented Sep 4, 2021

EasyVector commented Sep 4, 2021

EasyVector commented Sep 6, 2021

EasyVector commented Sep 6, 2021

EasyVector commented Sep 7, 2021

schildbach left a comment

schildbach Sep 7, 2021

EasyVector Sep 7, 2021

schildbach commented Sep 7, 2021

EasyVector commented Sep 7, 2021

schildbach commented Sep 9, 2021

schildbach commented Sep 9, 2021

Naywin220 left a comment

This comment was marked as spam.

Grek1313 left a comment

Dorineb07 left a comment

jimjohnson56 Aug 4, 2022

Benson665 commented Nov 8, 2022

Whiskey992 commented Nov 8, 2022 via email

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nElzky commented Nov 15, 2023

Fix the blocked camera icon on the main page #741

Are you sure you want to change the base?

Fix the blocked camera icon on the main page #741

Conversation

EasyVector commented Aug 31, 2021

Wahhe1 commented Sep 4, 2021

schildbach commented Sep 4, 2021

EasyVector commented Sep 4, 2021

EasyVector commented Sep 6, 2021

EasyVector commented Sep 6, 2021

EasyVector commented Sep 7, 2021

schildbach left a comment

Choose a reason for hiding this comment

schildbach Sep 7, 2021

Choose a reason for hiding this comment

EasyVector Sep 7, 2021

Choose a reason for hiding this comment

schildbach commented Sep 7, 2021

EasyVector commented Sep 7, 2021

schildbach commented Sep 9, 2021

schildbach commented Sep 9, 2021

Naywin220 left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

Grek1313 left a comment

Choose a reason for hiding this comment

Dorineb07 left a comment

Choose a reason for hiding this comment

jimjohnson56 Aug 4, 2022

Choose a reason for hiding this comment

Benson665 commented Nov 8, 2022

Whiskey992 commented Nov 8, 2022 via email

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nElzky commented Nov 15, 2023