BREAKING CHANGE: use ESM exports only #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on updating the project to use ECMAScript modules (ESM) and updating the package version. The most significant changes include the update of the package version in
package.json, the removal of CommonJS require inREADME.md, and the change of the import statement intests/index.test.js. TheREADME.mdfile has also been updated to reflect that the project now supports ESM, Node.js, and browsers.Package version update:
package.json: The package version has been updated from 4.1.5 to 5.0.0. This is a major version update, indicating that there might be breaking changes.ESM adoption:
README.md: The documentation has been updated to remove the CommonJS require example and replace it with the ESM import example. This is in line with the move towards ESM.tests/index.test.js: The import statement has been changed to use the ESM version ofextract-domain.Documentation update:
README.md: The "Supports" section has been updated to include ESM, Node.js, and browsers. This provides more clarity on the environments where the package can be used.