Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center connect box on page #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Center connect box on page #33

wants to merge 3 commits into from

Conversation

G07cha
Copy link
Member

@G07cha G07cha commented Nov 7, 2015

Moves "connect box" on center of the page and so, page not looks too much empty on large screens.
screen shot 2015-11-07 at 10 51 51 am

@kvnneff
Copy link
Collaborator

kvnneff commented Nov 10, 2015

The Box css component is used for every container across the app that has a blue border, so when checking out this branch the rest of the layout after signing in is unusable.

What you really want to change is the connect layout here, specifically the .Connect-boxContainer class.

I have to pass on the vertical centering, though, it doesn't look right to me. You can certainly push the box down some but I don't like it dead center on the page. If you check out gmail.com while not logged in that's what I was going for.

This page will be changing anyway since we're not using Electron. I'd like it to have more info on it like a landing page with game info, include links to github, etc.

@G07cha
Copy link
Member Author

G07cha commented Nov 10, 2015

@kvnneff, thanks for your detailed feedback, I've moved properties to the .Connect-boxContainer and now it's seems to look fine on Safari, Opera and Google Chrome. Also I've decreased top margin so we can add links on the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants