Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add last rendered page index to Paragraphs and Tables #671

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Czechh
Copy link
Sponsor

@Czechh Czechh commented Jan 3, 2024

What does this change?

Uses <w:lastRenderedPageBreak/> XML Element to keep track of the last rendered page. Then appends that page rendered index to paragraphs and tables.

References

@Czechh
Copy link
Sponsor Author

Czechh commented Jan 3, 2024

@bokuweb - I've been having some issue with replacing the snapshots with insta. I'm a newbie with this cargo.

cargo insta accept
error: Failed parsing the provided YAML text

Is there yaml in your vscode config or something else code editor specific i might be missing?

All of the cargo-insta/ insta commands fail. Make test does work to generate the new snapshots to compare.

@bokuweb
Copy link
Owner

bokuweb commented Jan 4, 2024

@Czechh Thanks!
I suspect it might be a bug with Insta.
I'll handle the updates on my end, so just ignore Insta for now.

@bokuweb
Copy link
Owner

bokuweb commented Jan 17, 2024

@Czechh

Sorry. Could you please try followin command and retry insta?

find docx-core/tests/snapshots/* | xargs sed -i '' 's/json"---/json"\n---/'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants