-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trigger workflow only for first recurring event #15128
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 319 Passing - ❌ 2 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/21/2024 03:13:34pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 8d2d27e Started: 05/21/2024 03:10:32pm UTC ❌ Failures📄 apps/web/playwright/profile.e2e.ts • 2 FailuresTop 1 Common Error Messages
Test Case Results
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 2 • Retry 1 • Initial Attempt |
4.60% (11)11 / 239 runsfailed over last 7 days |
21.34% (51)51 / 239 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Stripe integration Paid booking should be able to be rescheduled
Retry 1 • Initial Attempt |
5.91% (13)13 / 220 runsfailed over last 7 days |
15.91% (35)35 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
4.18% (10)10 / 239 runsfailed over last 7 days |
35.56% (85)85 / 239 runsflaked over last 7 days |
📄 apps/web/playwright/workflow.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Create an action and check if workflow is triggered
Retry 1 • Initial Attempt |
2.51% (6)6 / 239 runsfailed over last 7 days |
2.51% (6)6 / 239 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Managed Event Types Can create managed event type
Retry 1 • Initial Attempt |
5.96% (14)14 / 235 runsfailed over last 7 days |
4.26% (10)10 / 235 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1 • Initial Attempt |
0% (0)0 / 229 runsfailed over last 7 days |
32.31% (74)74 / 229 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.43% (1)1 / 232 runfailed over last 7 days |
29.74% (69)69 / 232 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1 • Initial Attempt |
3.40% (8)8 / 235 runsfailed over last 7 days |
34.04% (80)80 / 235 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Signup Flow Test Email verification sent if enabled
Retry 1 • Initial Attempt |
0.81% (2)2 / 246 runsfailed over last 7 days |
28.46% (70)70 / 246 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
8.94% (22)22 / 246 runsfailed over last 7 days |
25.20% (62)62 / 246 runsflaked over last 7 days |
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
8.13% (20)20 / 246 runsfailed over last 7 days |
30.49% (75)75 / 246 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
20.55% (52)52 / 253 runsfailed over last 7 days |
33.99% (86)86 / 253 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CarinaWolli i just tested this and it doesnt seem to work as i am still getting all the emails per scheduled event - am i misunderstanding something
@@ -2385,7 +2385,7 @@ async function handler( | |||
calendarEvent: evtWithMetadata, | |||
isNotConfirmed: rescheduleUid ? false : !isConfirmedByDefault, | |||
isRescheduleEvent: !!rescheduleUid, | |||
isFirstRecurringEvent: true, | |||
isFirstRecurringEvent: req.body.allRecurringDates ? req.body.isFirstRecurringSlot : true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isFirstRecurringEvent: req.body.allRecurringDates ? req.body.isFirstRecurringSlot : true, | |
isFirstRecurringEvent: req.body.allRecurringDates ? req.body.isFirstRecurringSlot : false, |
@@ -141,7 +141,7 @@ export const scheduleWorkflowReminders = async (args: ScheduleWorkflowRemindersA | |||
calendarEvent: evt, | |||
isNotConfirmed = false, | |||
isRescheduleEvent = false, | |||
isFirstRecurringEvent = false, | |||
isFirstRecurringEvent = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Udit-takkar isFirstRecurringEvent
should default to true
if it is normal event and not recurring. Why? The first recurring event is handled the same as a normal event
@sean-brydon is that a workflow email? looks like the broken integration email |
Sorry for the late reply on this - slipped my inbox. I've just tested this again and im seeing the same issue :/ I logged out and send email is still being called N times for the number of recuring events so im not sure its something to do with the email integration 🤔 Will have a dig around |
That's weird. Could you provide the steps how you are testing it? That's how I test it:
|
Well - it turns out there was an issue with my mail setup - had four containers running somehow and they were all receiving emails. Works fine now :D Sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This fixes that a workflow with the 'when new event is booked' trigger is only triggered for the first recurring event