revert: refactor: api v2 schedules #15130
Conversation
This reverts commit c25c835.
|
Issue reopened: CAL-3580 [Api][v2] schedules endpoints should be client agnostic |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Current Playwright Test Results Summary✅ 34 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/20/2024 04:25:50pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 13e1a67 Started: 05/20/2024 04:24:51pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 2 • Retry 1 • Initial Attempt |
12.27% (33)33 / 269 runsfailed over last 7 days |
29.74% (80)80 / 269 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
supalarry
deleted the
revert-14870-lauris/cal-3580-apiv2-schedules-endpoints-should-be-client-agnostic
branch
Reverts #14870
Me and @keithwillcode discussed that it's best to postpone breaking api changes until we have versioning.
We don't know the metrics of how many people use schedule atom in production nor how many use schedule hooks or make manualy api requests, and for users' production not to break it would mean coordinating with them to update their api calls & hooks ahead of release, and then atoms package during the release.
I will revert this revert and keep it open until the versioning is ready.