Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide option to allow rescheduling with the same round-robin host #15132

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented May 20, 2024

What does this PR do?

Screenshot 2024-05-20 214649

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented May 20, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 20, 2024
@graphite-app graphite-app bot requested a review from a team May 20, 2024 15:55
Copy link
Contributor

github-actions bot commented May 20, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request labels May 20, 2024
Copy link

graphite-app bot commented May 20, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 279.16 KB 507.75 KB 145.07% (🟢 -0.31%)
/apps/[slug] 296.66 KB 525.25 KB 150.07% (🟢 -0.31%)
/apps/[slug]/[...pages] 587.65 KB 816.23 KB 233.21% (🟢 -0.32%)
/apps/categories 256.89 KB 485.48 KB 138.71% (🟢 -0.31%)
/apps/categories/[category] 261.24 KB 489.82 KB 139.95% (🟢 -0.31%)
/apps/installed/[category] 280.43 KB 509.01 KB 145.43% (🟢 -0.31%)
/availability 427.89 KB 656.48 KB 187.57% (🟢 -0.32%)
/availability/[schedule] 411.64 KB 640.22 KB 182.92% (🟢 -0.31%)
/bookings/[status] 324.73 KB 553.31 KB 158.09% (🟢 -0.31%)
/enterprise 256.95 KB 485.53 KB 138.72% (🟢 -0.31%)
/event-types 556.64 KB 785.22 KB 224.35% (🟢 -0.32%)
/event-types/[type] 436.54 KB 665.12 KB 190.03% (🟢 -0.31%)
/insights 475.86 KB 704.44 KB 201.27% (🟢 -0.31%)
/more 256.46 KB 485.04 KB 138.58% (🟢 -0.31%)
/settings/admin 262.55 KB 491.14 KB 140.32% (🟢 -0.31%)
/settings/admin/apps 275.69 KB 504.27 KB 144.08% (🟢 -0.31%)
/settings/admin/apps/[category] 275.67 KB 504.25 KB 144.07% (🟢 -0.31%)
/settings/admin/flags 266.66 KB 495.25 KB 141.50% (🟢 -0.31%)
/settings/admin/impersonation 263.04 KB 491.62 KB 140.46% (🟢 -0.31%)
/settings/admin/lockedSMS 283.71 KB 512.29 KB 146.37% (🟢 -0.31%)
/settings/admin/oAuth 274.71 KB 503.3 KB 143.80% (🟢 -0.31%)
/settings/admin/orgMigrations/_OrgMigrationLayout 251.47 KB 480.05 KB 137.16% (🟢 -0.31%)
/settings/admin/orgMigrations/moveTeamToOrg 300.63 KB 529.22 KB 151.20% (🟢 -0.30%)
/settings/admin/orgMigrations/moveUserToOrg 320.04 KB 548.62 KB 156.75% (🟢 -0.31%)
/settings/admin/orgMigrations/removeTeamFromOrg 300.38 KB 528.96 KB 151.13% (🟢 -0.31%)
/settings/admin/orgMigrations/removeUserFromOrg 300.39 KB 528.97 KB 151.14% (🟢 -0.31%)
/settings/admin/organizations 264.12 KB 492.7 KB 140.77% (🟢 -0.31%)
/settings/admin/organizations/[id]/edit 262.94 KB 491.52 KB 140.43% (🟢 -0.31%)
/settings/admin/users 264.8 KB 493.38 KB 140.97% (🟢 -0.31%)
/settings/admin/users/[id]/edit 393.49 KB 622.07 KB 177.74% (🟢 -0.31%)
/settings/admin/users/add 393.22 KB 621.8 KB 177.66% (🟢 -0.31%)
/settings/billing 262.66 KB 491.24 KB 140.35% (🟢 -0.31%)
/settings/developer/api-keys 266.71 KB 495.3 KB 141.51% (🟢 -0.31%)
/settings/developer/webhooks 266.81 KB 495.39 KB 141.54% (🟢 -0.31%)
/settings/developer/webhooks/[id] 267.8 KB 496.39 KB 141.83% (🟢 -0.32%)
/settings/developer/webhooks/new 267.8 KB 496.38 KB 141.82% (🟢 -0.31%)
/settings/my-account/appearance 315.53 KB 544.11 KB 155.46% (🟢 -0.31%)
/settings/my-account/calendars 273.23 KB 501.82 KB 143.38% (🟢 -0.31%)
/settings/my-account/conferencing 274.5 KB 503.09 KB 143.74% (🟢 -0.31%)
/settings/my-account/general 378.43 KB 607.02 KB 173.43% (🟢 -0.31%)
/settings/my-account/out-of-office 267.33 KB 495.92 KB 141.69% (🟢 -0.31%)
/settings/my-account/profile 405.98 KB 634.56 KB 181.30% (🟢 -0.31%)
/settings/organizations/admin-api 262.56 KB 491.14 KB 140.33% (🟢 -0.31%)
/settings/organizations/appearance 286.61 KB 515.2 KB 147.20% (🟢 -0.31%)
/settings/organizations/billing 262.74 KB 491.32 KB 140.38% (🟢 -0.31%)
/settings/organizations/dsync 294.84 KB 523.42 KB 149.55% (🟢 -0.31%)
/settings/organizations/general 350.41 KB 578.99 KB 165.43% (🟢 -0.32%)
/settings/organizations/members 400.19 KB 628.77 KB 179.65% (🟢 -0.31%)
/settings/organizations/privacy 268.32 KB 496.91 KB 141.97% (🟢 -0.31%)
/settings/organizations/profile 398.73 KB 627.31 KB 179.23% (🟢 -0.31%)
/settings/organizations/sso 273.4 KB 501.99 KB 143.42% (🟢 -0.31%)
/settings/organizations/teams/other 263.31 KB 491.89 KB 140.54% (🟢 -0.31%)
/settings/organizations/teams/other/[id]/appearance 275.45 KB 504.03 KB 144.01% (🟢 -0.31%)
/settings/organizations/teams/other/[id]/members 270.4 KB 498.98 KB 142.57% (🟢 -0.31%)
/settings/organizations/teams/other/[id]/profile 469.54 KB 698.13 KB 199.46% (🟢 -0.31%)
/settings/security/impersonation 267.56 KB 496.15 KB 141.76% (🟢 -0.31%)
/settings/security/password 305.14 KB 533.72 KB 152.49% (🟢 -0.31%)
/settings/security/sso 272.73 KB 501.31 KB 143.23% (🟢 -0.31%)
/settings/security/two-factor-auth 270.99 KB 499.57 KB 142.74% (🟢 -0.32%)
/settings/teams 262.22 KB 490.8 KB 140.23% (🟢 -0.31%)
/settings/teams/[id]/appearance 275.43 KB 504.02 KB 144.01% (🟢 -0.32%)
/settings/teams/[id]/billing 262.74 KB 491.32 KB 140.38% (🟢 -0.31%)
/settings/teams/[id]/members 380.43 KB 609.01 KB 174.00% (🟢 -0.31%)
/settings/teams/[id]/profile 470.38 KB 698.96 KB 199.70% (🟢 -0.31%)
/teams 256.68 KB 485.27 KB 138.65% (🟢 -0.31%)
/upgrade 256.81 KB 485.39 KB 138.68% (🟢 -0.31%)
/video/[uid] 295.84 KB 524.42 KB 149.83% (🟡 +1.37%)
/workflows 288.15 KB 516.74 KB 147.64% (🟢 -0.32%)
/workflows/[workflow] 410.58 KB 639.17 KB 182.62% (🟢 -0.31%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@keithwillcode keithwillcode added this to the v4.3 milestone May 20, 2024
@anikdhabal anikdhabal changed the title feat: provide option to allow rescheduling with the same round-robin feat: provide option to allow rescheduling with the same round-robin host May 21, 2024
@dosubot dosubot bot modified the milestones: v4.3, v4.4 Jun 3, 2024
@PeerRich PeerRich modified the milestones: v4.3, v4.4 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync event-types area: event types, event-types ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3556] Reschedule round robin to same host
3 participants