Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support anchorRef on PopoverAnchor #8173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xeinebiu
Copy link

@xeinebiu xeinebiu commented Dec 18, 2023

📝 Description

Adds a possibility on PopoverAnchor component to pass anchorRef. This ensures us we can reuse the same popover with different anchors on different use cases.

image

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying
There are third party libraries whose we cannot wrap inside PopoverAnchor to display a Popover on a click event.

🚀 New behavior

Please describe the behavior or changes this PR adds
PopoverAnchor can either accept children or anchorRef to position the Popover. anchorRef can be an element on a 3rd party library which dispatched a click event and we want to display the popover for that element.

💣 Is this a breaking change (Yes/No):

  • No

📝 Additional Information

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: f935853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chakra-ui/popover Major
@chakra-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Dec 19, 2023 8:44am

@JAD3N
Copy link

JAD3N commented Mar 19, 2024

Is there any chance this will get merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants