Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesnt work on 10.0.0 #194

Closed
LoganMD opened this issue May 4, 2018 · 4 comments · May be fixed by #198
Closed

Doesnt work on 10.0.0 #194

LoganMD opened this issue May 4, 2018 · 4 comments · May be fixed by #198

Comments

@LoganMD
Copy link

LoganMD commented May 4, 2018

It just wont build, run, or anything.
@CaptainYarb
Copy link

We were able to run this in NodeJS 10 in a docker container. You may have an issue with your local install or system. Might be worthwhile to get more context to your runtime environment.

@redders6600
Copy link

@CaptainYarb I also cannot build with 10, I get the error listed in #195.
I'm actually using electron 3 then using electron-rebuild.

make: Entering directory '/data/hdd/dev/flare-electron/node_modules/pty.js/build'
  CXX(target) Release/obj.target/pty/src/unix/pty.o
In file included from ../node_modules/nan/nan.h:190:0,
                 from ../src/unix/pty.cc:20:
../node_modules/nan/nan_maybe_43_inl.h: In function ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’:
../node_modules/nan/nan_maybe_43_inl.h:88:15: error: ‘class v8::Object’ has no member named ‘ForceSet’
   return obj->ForceSet(GetCurrentContext(), key, value, attribs);
               ^~~~~~~~

@raziel057
Copy link

Same error on my side with node 11.2.0

@risacher risacher mentioned this issue Jan 29, 2019
Open
@LoganMD LoganMD closed this as completed Mar 14, 2019
@Tyriar
Copy link

Tyriar commented Apr 28, 2019

FYI I maintain a fork of pty.js that has advanced quite a bit https://github.com/Microsoft/node-pty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update package.json for new version of nan risacher/pty.js
5 participants
@CaptainYarb @raziel057 @Tyriar @redders6600 @LoganMD