Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package.json for new version of nan #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

risacher
Copy link

fixes #194 and #195

@wwwy3y3
Copy link

wwwy3y3 commented Feb 3, 2019

+1 on this PR. kudos to @risacher.

For people bumped into related issues and still waiting for this PR, you can use npm-shrinkwrap to force the nan version.

Example:

{
  "name": "<your package name>",
  "version": "<your package version>",
  "lockfileVersion": 1,
  "dependencies": {
    "pty.js": {
      "version": "0.3.1",
      "from": "pty.js@0.3.1",
      "dependencies": {
        "nan": {
          "version": "2.12.1",
          "from": "nan@2.12.1"
        }
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesnt work on 10.0.0
2 participants