just merged this in case someone wants to use it... #102
Conversation
may be race-y due to always storing latest in global. might want to use a map of some sort.
fixing interoperability with native child_process. also added tests
check the sigchld handler
fixing OSX build * soumith/master: fixing OSX build
Switch to new Streams API. * Gottox/newStreams: use Terminal.super_ instead of hard coded parent constructor. use new streams instead of old "data" API.
Merge pull request chjj#37 from niallo/waitpid Report status code of child process in `term.status` property * niallo/waitpid: missed test file adding travis node 0.10 compatibility set SA_NOCLDSTOP flag for SIGCHLD handler must set exit status correctly fixing interoperability with native child_process. also added tests call node/libuv's SIGCHLD handler. zap status property which krept in. demonstrate fetching exit status use a PID -> exit code map to avoid race conditions. save exit status of child via SIGCHLD handler and waitpid(3) may be race-y due to always storing latest in global. might want to use a map of some sort. Conflicts: lib/pty.js src/unix/pty.cc
|
Any update on getting this merged? |
|
I used this version a while ago, but I imagine it's out of date now. I suppose I could rebase it and fix it if there's interest.. |
|
I'm mostly interested in the SIGCHLD code. If we could get that into a separate PR, that would be good. |
|
That's the part I'm interested in getting in also. Would be great if we
|
|
so, what needs to be done then, exactly? (besides the rebase) thing is, I don't really have the time at this moment. perhaps next week? |
#91 (OSX fixes) & #94 (new streams) & #37 (child status code) were all merged. though, I have not really tried this out extensively yet (this afternoon's task).
well, cheers